RFR: 8343140: JfrJavaSupport uses the wrong accessors for sub-int fields

Aleksey Shipilev shade at openjdk.org
Fri Nov 8 10:08:45 UTC 2024


On Thu, 7 Nov 2024 21:13:32 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> src/hotspot/share/jfr/jni/jfrJavaSupport.cpp line 347:
>> 
>>> 345:     case T_SHORT:
>>> 346:       Unimplemented();
>>> 347:       break;
>> 
>> Why not implement these, while we are at it?
>
> because it's more work, and we probably "Ain't Gonna Need It". The method is 6 years old, and is only used in one place.
> That being said, if you think these types might be useful in a predictable future, I can implement them.

Let's implement them. As it stands in current mainline, these methods are "implemented", albeit incorrectly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21952#discussion_r1834065900


More information about the hotspot-jfr-dev mailing list