RFR: 8343140: JfrJavaSupport uses the wrong accessors for sub-int fields [v2]

Erik Gahlin egahlin at openjdk.org
Tue Nov 12 17:55:34 UTC 2024


On Tue, 12 Nov 2024 16:49:15 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:

>> This test fixes the accessor used by `read_boolean_field` to access boolean fields of the `jdk.jfr.internal.dcmd.Argument` record. It also fixes the read accessors for `short` and `char` types, and marks the write accessors for `boolean`, `short` and `char` as unimplemented.
>> 
>> The existing accessor reads the boolean field as int. This results in unaligned access, and probably reads incorrect value on big-endian CPUs.
>> 
>> No new tests. I'm sure a test would be useful, but I have no idea how to write one. Existing tier1-3 tests continue to pass.
>
> Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Implement write accessors

Marked as reviewed by egahlin (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21952#pullrequestreview-2430318886


More information about the hotspot-jfr-dev mailing list