Integrated: 8343140: JfrJavaSupport uses the wrong accessors for sub-int fields
Daniel Jeliński
djelinski at openjdk.org
Wed Nov 13 13:29:00 UTC 2024
On Thu, 7 Nov 2024 12:57:20 GMT, Daniel Jeliński <djelinski at openjdk.org> wrote:
> This test fixes the accessor used by `read_boolean_field` to access boolean fields of the `jdk.jfr.internal.dcmd.Argument` record. It also fixes the read accessors for `short` and `char` types, and marks the write accessors for `boolean`, `short` and `char` as unimplemented.
>
> The existing accessor reads the boolean field as int. This results in unaligned access, and probably reads incorrect value on big-endian CPUs.
>
> No new tests. I'm sure a test would be useful, but I have no idea how to write one. Existing tier1-3 tests continue to pass.
This pull request has now been integrated.
Changeset: b72fe755
Author: Daniel Jeliński <djelinski at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/b72fe75533f1115076ec083faba56318156aba2a
Stats: 30 lines in 1 file changed: 30 ins; 0 del; 0 mod
8343140: JfrJavaSupport uses the wrong accessors for sub-int fields
Reviewed-by: shade, egahlin
-------------
PR: https://git.openjdk.org/jdk/pull/21952
More information about the hotspot-jfr-dev
mailing list