RFR: 8343780: Add since checker tests to the Tools area modules and add missing @since to jdk.jfr.Recording [v2]
Nizar Benalla
nbenalla at openjdk.org
Thu Nov 14 01:28:15 UTC 2024
> Can I please get a review for this PR that add tests to verify the value of `@since` tags to the Tools area modules. The test is described in this [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html). This issue is similar to JDK-8341399, JDK-8331051 and JDK-8343442.
>
> The benefit from this is helping API authors and reviewer validate the accuracy of `@since` in their source code (and subsequently, in the generated documentation). And lessen the burden on Reviewers.
>
> The test has been added for `java.base` and a few other modules and has helped catch some bugs before they make it to the JDK.
>
> Notes:
> - I have also added an `@since` tag that was missing.
> - You will notice there is no test for the `jdk.jfr` module, it will be added in a future PR because it requires special handling. (JFR used to be a commercial feature and this requires special handling to be added for it in the test)
>
> TIA
Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
Add backticks, as they are necessary. Otherwise the `@since` is treated as a jtreg tag
Revert "remove backticks"
This reverts commit 83afb011685a4bc09bc994dd9a8891f6cdfe7217.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21982/files
- new: https://git.openjdk.org/jdk/pull/21982/files/83afb011..c1615b31
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21982&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21982&range=00-01
Stats: 6 lines in 5 files changed: 0 ins; 1 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/21982.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21982/head:pull/21982
PR: https://git.openjdk.org/jdk/pull/21982
More information about the hotspot-jfr-dev
mailing list