RFR: 8344071: Mark some jdk/jfr/event/oldobject test flagless until they fixed to support all GC

Leonid Mesnik lmesnik at openjdk.org
Thu Nov 14 18:01:39 UTC 2024


On Thu, 14 Nov 2024 17:41:38 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Tests
>> jdk/jfr/event/oldobject/TestObjectDescription.java
>> jdk/jfr/event/oldobject/TestClassLoaderLeak.java
>> fail with different GCs to get expected events.
>> 
>> They pass with G1 GC so I don't want to problemlist them.
>> However, they should test all GCs that support these events.
>> 
>> Removed ZGC, because I expect that is Generational and should be also supported.
>> 
>> The flagless should be removed when the main bugs are fixed.
>
> test/jdk/jdk/jfr/event/oldobject/TestObjectDescription.java line 44:
> 
>> 42:  * @key jfr
>> 43:  * @requires vm.hasJFR
>> 44:  * @requires vm.gc != "Z" & vm.gc != "Shenandoah"
> 
> Why did you remove the exclusion of ZGC here and left Shenandoah? Isn't it better to leave the ZGC exclusion here?

The ZGC is now generational, and the OldObjectSampler should work.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22050#discussion_r1842668288


More information about the hotspot-jfr-dev mailing list