RFR: 8343893: Test jdk/jfr/event/runtime/TestNativeMemoryUsageEvents.java failed: heap should have grown and NMT should show that: expected 0 > 0 [v4]

[Gerard Ziemski]

On Tue, 19 Nov 2024 16:41:00 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove ZGC run test
>
> src/hotspot/share/nmt/nmtUsage.cpp line 105:
> 
>> 103:       _vm_total.committed += vm->committed();
>> 104:     });
>> 105:   }
> 
> I am missing something here, in memoryFileTracker.hpp you say:
> 
> 
> // All memory is accounted as committed, there is no reserved memory.
> // Any reserved memory is expected to exist in the VirtualMemoryTracker.
> 
> 
> but here we use MFT to account for both reserved and committed?

Ah, we actually do use VirtualMemory here to track the memory. Never mind!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22204#discussion_r1848714196