RFR: 8343893: Test jdk/jfr/event/runtime/TestNativeMemoryUsageEvents.java failed: heap should have grown and NMT should show that: expected 0 > 0 [v4]

[Johan Sjölen]

On Wed, 20 Nov 2024 08:39:31 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Ah, we actually do use VirtualMemory here to track the memory. Never mind!
>
> Yeah, but it is actually 0 :). I wanted to future proof this code, if we ever do use `reserved` here. I'll assert that `reserved` is 0 with a good message, then we can fix the code if our assumptions change.

Sorry, I was pretty confused here. We need to remove the reserved additions, otherwise we double-account reserved memory.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22204#discussion_r1851785179