Integrated: 8343893: Test jdk/jfr/event/runtime/TestNativeMemoryUsageEvents.java failed: heap should have grown and NMT should show that: expected 0 > 0
Johan Sjölen
jsjolen at openjdk.org
Fri Nov 22 08:58:22 UTC 2024
On Mon, 18 Nov 2024 11:44:41 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> # Background
>
> With the implementation of [JDK-8312132](https://bugs.openjdk.org/browse/JDK-8312132) we added the `MemoryFileTracker` (MFT). Unfortunately, this work failed to implement JFR integration. This, in turn, meant that (generational) ZGC has not correctly reported its heap usage via the NMT JFR events. We (as in Oracle) never saw this issue in testing, as we didn't run this test for all possible GC configurations. With an update of our test configurations this is no longer the case: We run this test for all possible GCs and the test now fails for generational ZGC.
>
> # The fix
>
> I implemented JFR events for the MFT by adding all of its reserved and committed memory into the JFR data, similarly to the `VirtualMemoryTracker`. I also added an explicit `run` using `ZGC` to the failing test, to ensure that any actual regressions are found.
This pull request has now been integrated.
Changeset: 2ea0364b
Author: Johan Sjölen <jsjolen at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/2ea0364b6e3f10977f7b607d239c29ee616a8f7c
Stats: 40 lines in 5 files changed: 29 ins; 6 del; 5 mod
8343893: Test jdk/jfr/event/runtime/TestNativeMemoryUsageEvents.java failed: heap should have grown and NMT should show that: expected 0 > 0
Reviewed-by: gziemski, mgronlun, lmesnik
-------------
PR: https://git.openjdk.org/jdk/pull/22204
More information about the hotspot-jfr-dev
mailing list