RFR: 8343026: JFR: Index into fields in the topFrame

Andrey Turbanov aturbanov at openjdk.org
Mon Oct 28 20:49:46 UTC 2024


On Fri, 25 Oct 2024 07:30:56 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a change that allows 'jfr view' queries to reference nested fields for a top frame.
> 
> Testing: jdk/jdk/jfr and diff of 'jfr view all-views' before and after the change.
> 
> This change will not impact the output of the exiting views, but it helps OpenJDK developers diagnose issues, for example, print 'lineNumber', (frame) 'type' and 'bytecodeIndex' of the top frame.
> 
> Thanks
> Erik

src/jdk.jfr/share/classes/jdk/jfr/internal/query/FieldBuilder.java line 177:

> 175: 
> 176:     private static RecordedFrame topFrame(RecordedEvent event) {
> 177:         return findJavaFrame(event,  x -> true);

Suggestion:

        return findJavaFrame(event, x -> true);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21705#discussion_r1819741115


More information about the hotspot-jfr-dev mailing list