RFR: 8343026: JFR: Index into fields in the topFrame [v2]

Markus Grönlund mgronlun at openjdk.org
Tue Oct 29 14:16:11 UTC 2024


On Tue, 29 Oct 2024 14:06:54 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review of a change that allows 'jfr view' queries to reference nested fields for a top frame.
>> 
>> Testing: jdk/jdk/jfr and diff of 'jfr view all-views' before and after the change.
>> 
>> This change will not impact the output of the exiting views, but it helps OpenJDK developers diagnose issues, for example, print 'lineNumber', (frame) 'type' and 'bytecodeIndex' of the top frame.
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove whitespace

Marked as reviewed by mgronlun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/21705#pullrequestreview-2402045307


More information about the hotspot-jfr-dev mailing list