RFR: 8343177: JFR: Remove critical section for thread id assignment [v2]

[David Holmes]

On Thu, 31 Oct 2024 05:02:59 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Okay so nothing inherently related to the critical section removal, just an API cleanup.
>
> Actually the more I look at this the more I dislike the fact `set_as_starting_thread` also calls `os::create_main_thread`. Seems to me that should be done directly by the caller, and if successful we call `set_as_starting_thread`. But that is a different cleanup.

Just FTR `set_as_starting_thread` originally only called `os::create_main_thread` so why it even existed is a bit of a mystery. The actual `_starting_thread` variable was something I added under JDK-8214097.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21756#discussion_r1823790011