RFR: 8343177: JFR: Remove critical section for thread id assignment [v2]

Markus Grönlund mgronlun at openjdk.org
Thu Oct 31 10:16:29 UTC 2024


On Thu, 31 Oct 2024 05:07:35 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   can_assign
>
> src/hotspot/share/jfr/jfr.cpp line 104:
> 
>> 102: 
>> 103: void Jfr::initialize_primordial_thread(JavaThread* jt) {
>> 104:   JfrThreadLocal::initialize_primordial_thread(jt);
> 
> The main thread is generally not the process primordial thread. Can we use main_thread or starting_thread here to keep semi-consistent with the Thread/Threads code terminology? Thanks

Ok.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21756#discussion_r1824207566


More information about the hotspot-jfr-dev mailing list