RFR: 8352251: Implement Cooperative JFR Sampling [v3]
Aleksey Shipilev
shade at openjdk.org
Mon Apr 7 10:12:49 UTC 2025
On Fri, 28 Mar 2025 20:09:37 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Markus Grönlund has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - align params
>> - adjustments
>
> src/hotspot/cpu/x86/interp_masm_x86.cpp line 1045:
>
>> 1043: Label slow_path;
>> 1044: Label fast_path;
>> 1045: safepoint_poll(slow_path, rthread, current_fp, true /* at_return */, false /* in_nmethod */);
>
> A little heads-up: I am going to propose a little cleanup soon to drop `rthread` from x86 safepoint_pool (we can trust it is `r15_thread` always). That would probably yield a minor merge conflict here.
FYI, it would be here: https://github.com/openjdk/jdk/pull/24323
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24296#discussion_r2030922573
More information about the hotspot-jfr-dev
mailing list