RFR: 8295651: JFR: 'jfr scrub' should summarize what was removed
Markus Grönlund
mgronlun at openjdk.org
Wed Apr 16 12:18:54 UTC 2025
On Tue, 15 Apr 2025 22:22:17 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of an enhancement that summarizes the results of `jfr scrub`?
>
> To accommodate this feature, I made some additional changes:
>
> - Added a LongMap::values() method.
> - Added a Command::printf(...) method, which is now also used by `jfr summary`.
> - Improved TestScrub.java so it now creates a file that spans multiple chunks, including an empty one.
>
> To make it easier to locate the scrubbed file, I also changed so the real path instead of the of the absolute path is displayed in the summary
>
> See issue for example output.
>
> Testing: jdk/jdk/jfr
>
> Thanks
> Erik
Brilliant change. Thank you for doing it.
-------------
Marked as reviewed by mgronlun (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24669#pullrequestreview-2772299050
More information about the hotspot-jfr-dev
mailing list