RFR: 8354949: JFR: Split up the EventInstrumentation class [v3]
Erik Gahlin
egahlin at openjdk.org
Fri Apr 18 12:03:43 UTC 2025
> Could I have a review of a PR that cleans up the EventInstrumentation class and moves the non-modifying parts into a separate class (ClassInspector)?
>
> I deleted the code that removes the instrumentation (buildUninstrumented), because it has never been used. If there should be a need for it in the future, it's not hard to add code that inserts empty method bodies.
>
> Testing: tier1 + jdk/jdk/jfr/test
>
> Thanks
> Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Minor fixes
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/24726/files
- new: https://git.openjdk.org/jdk/pull/24726/files/8ecb2732..07a56859
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=24726&range=02
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=24726&range=01-02
Stats: 12 lines in 3 files changed: 6 ins; 1 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/24726.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/24726/head:pull/24726
PR: https://git.openjdk.org/jdk/pull/24726
More information about the hotspot-jfr-dev
mailing list