RFR: 8354949: JFR: Split up the EventInstrumentation class [v4]

Chen Liang liach at openjdk.org
Tue Apr 22 15:46:47 UTC 2025


On Fri, 18 Apr 2025 12:08:53 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review of a PR that cleans up the EventInstrumentation class and moves the non-modifying parts into a separate class (ClassInspector)? 
>> 
>> I deleted the code that removes the instrumentation (buildUninstrumented), because it has never been used. If there should be a need for it in the future, it's not hard to add code that inserts empty method bodies.
>> 
>> Testing: tier1 + jdk/jdk/jfr/test
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove accidentally added printStackTrace()

ClassFile API usages look good.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24726#pullrequestreview-2784562744


More information about the hotspot-jfr-dev mailing list