Integrated: 8354949: JFR: Split up the EventInstrumentation class
Erik Gahlin
egahlin at openjdk.org
Wed Apr 23 11:51:49 UTC 2025
On Thu, 17 Apr 2025 14:11:25 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of a PR that cleans up the EventInstrumentation class and moves the non-modifying parts into a separate class (ClassInspector)?
>
> I deleted the code that removes the instrumentation (buildUninstrumented), because it has never been used. If there should be a need for it in the future, it's not hard to add code that inserts empty method bodies.
>
> Testing: tier1 + jdk/jdk/jfr/test
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: ef0cd182
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/ef0cd1823d7d57e42e66255a0e80bfa495a7102d
Stats: 980 lines in 5 files changed: 451 ins; 359 del; 170 mod
8354949: JFR: Split up the EventInstrumentation class
Reviewed-by: mgronlun, liach
-------------
PR: https://git.openjdk.org/jdk/pull/24726
More information about the hotspot-jfr-dev
mailing list