RFR: 8352251: Implement Cooperative JFR Sampling [v11]

[Aleksey Shipilev]

On Wed, 23 Apr 2025 23:08:41 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> This is the implementation of JEP [JDK-8350338 Cooperative JFR Sampling](https://bugs.openjdk.org/browse/JDK-8350338).
>> 
>> Implementations in this change set are provided and have been tested on the following platforms:
>> 
>> - windows-x64
>> - windows-x64-debug
>> - linux-x64
>> - linux-x64-debug
>> - macosx-x64
>> - macosx-x64-debug
>> - linux-aarch64
>> - linux-aarch64-debug
>> - macosx-aarch64
>> - macosx-aarch64-debug
>> 
>> Testing: tier1-6, jdk_jfr, stress testing.
>> 
>> Platform porters note:
>> Some platform-specific code needs to be provided, mainly in the interpreter. Take a look at the following files for changes:
>> 
>> - src/hotspot/cpu/x86/frame_x86.cpp
>> - src/hotspot/cpu/x86/interp_masm_x86.cpp
>> - src/hotspot/cpu/x86/interp_masm_x86.hpp
>> - src/hotspot/cpu/x86/javaFrameAnchor_x86.hpp
>> - src/hotspot/cpu/x86/macroAssembler_x86.cpp
>> - src/hotspot/cpu/x86/macroAssembler_x86.hpp
>> - src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp
>> - src/hotspot/cpu/x86/templateTable_x86.cpp
>> - src/hotspot/os_cpu/linux_x86/javaThread_linux_x86.hpp
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   No invariants for sender_for_interpreter_frame

(Sorry for dripping review comments, I have only limited time a day to look at this)

Looks like windows-aarch64 GHA build fails with:


d:\a\jdk\jdk\src\hotspot\cpu\aarch64\interp_masm_aarch64.cpp(475): error C2039: 'last_sender_Java_fp_offset': is not a member of 'JavaThread'
d:\a\jdk\jdk\src\hotspot\share\runtime/threads.hpp(34): note: see declaration of 'JavaThread'


I suspect the fix is as simple as adding the hunk that you already have in `javaThread_windows_x86.hpp` to `javaThread_windows_aarch64.hpp` as well.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24296#issuecomment-2826904990