RFR: 8365610: Sort share/jfr includes
Francesco Andreuzzi
duke at openjdk.org
Fri Aug 15 13:37:52 UTC 2025
On Fri, 15 Aug 2025 13:30:33 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
> This PR sorts the includes in hotspot/share/jfr using SortIncludes.java. I'm also adding the directory to TestIncludesAreSorted.
>
> Passes tier1.
src/hotspot/share/jfr/periodic/jfrOSInterface.cpp line 35:
> 33: #include "utilities/ostream.hpp"
> 34:
> 35: #include <stdlib.h> // for environment variables
I couldn't find any usage for this include, let me know if it should stay. It's been here for a long time: https://github.com/openjdk/jdk/commit/a060be188df894ed5c26fc12fc9e902f9af32bd3
src/hotspot/share/jfr/support/jfrDeprecationManager.cpp line 52:
> 50: #include "runtime/thread.inline.hpp"
> 51:
> 52: // for strstr
Let me know if the comment should stay
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26800#discussion_r2278998210
PR Review Comment: https://git.openjdk.org/jdk/pull/26800#discussion_r2278998848
More information about the hotspot-jfr-dev
mailing list