RFR: 8365533: Remove outdated jdk.internal.javac package export to several modules from java.base [v2]
Jaikiran Pai
jpai at openjdk.org
Mon Aug 18 06:48:19 UTC 2025
On Mon, 18 Aug 2025 04:49:28 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of these change which removes the outdated use of `jdk.internal.javac.ParticipatesInPreview` and the qualified export of `jdk.internal.javac` package? This addresses https://bugs.openjdk.org/browse/JDK-8365533.
>>
>> These qualified exports in `java.base` were added in https://bugs.openjdk.org/browse/JDK-8308753 when ClassFile API was in preview. Starting Java 24, ClassFile API is now a part of Java SE. These affected modules don't use any other preview feature, so there's no longer a need to export the `jdk.internal.javac` package to these modules.
>>
>> tier1, tier2 and tier3 testing of this change completed without any related failures.
>
> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
>
> - merge latest from master branch
> - 8365533: Remove outdated jdk.internal.javac package export to several modules from java.base
Thank you Alan and Chen for the reviews.
tier1, tier2 and tier3 testing with this change completed without any related issues.
> In addition, `PreviewFeature.Feature` enum has a few obsolete entries ... Now the boot JDK is min 24, and a few of the features are already permanent in 24.
I'll file a separate issue to clean those up.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26776#issuecomment-3195338107
More information about the hotspot-jfr-dev
mailing list