RFR: 8365610: Sort share/jfr includes

[Aleksey Shipilev]

On Mon, 18 Aug 2025 10:43:38 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

> A blanket HotSpot change that does not add much value, but instead creates an unnecessary dependency that will make development of JFR more problematic.

It is not "blanket", is it? The includes get sorted component by component, and many components in Hotspot have already been processed, with a long view of entire Hotspot being covered. Overall, while I agree maintaining the include order hygiene would require additional work, that is true for _any_ hygiene work. It does not mean we refrain from it. What we do is to make sure the detection is as prompt and the fixes are as easy as practically possible.

Also, there is already a "dependency" on source tests. For example, if you write `NULL` anywhere in JFR code, this test would fail: https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/sources/TestNoNULL.java. You'll get a failure with any `tier1` testing, including GHA checks. The include order test is not that different.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26800#issuecomment-3196274329