RFR: 8365636: JFR: Minor cleanup [v2]

Aleksey Shipilev shade at openjdk.org
Mon Aug 18 11:51:13 UTC 2025


On Mon, 18 Aug 2025 07:00:01 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have review of Pr That cleans up various stuff (unnecessary imports, typos etc).
>> 
>> Testing: jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Compare with class instead incorrect/reversed isAssignableFrom

Looks fine to me, I just have one question:

src/jdk.jfr/share/classes/jdk/jfr/consumer/RecordedObject.java line 186:

> 184:         }
> 185:         T object = getValue(name);
> 186:         if (object == null || object.getClass() == clazz) {

Comprehension check: looks like do not need to check hierarchy at all, since we only ever call `getTyped` with `final` classes, correct?

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26811#pullrequestreview-3128046871
PR Review Comment: https://git.openjdk.org/jdk/pull/26811#discussion_r2282171802


More information about the hotspot-jfr-dev mailing list