RFR: 8365610: Sort share/jfr includes
Aleksey Shipilev
shade at openjdk.org
Tue Aug 19 10:13:41 UTC 2025
On Mon, 18 Aug 2025 15:53:50 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
> > For Hotspot changes, you need to wait 24 hours, so people around the globe could take a look.
>
> Sure, so is it 24 hours after getting approval? I thought it's 24 hours after opening the PR.
Ah no, you're right: https://openjdk.org/guide/#life-of-a-pr -- 24 hours is the bare minimum. It gets a bit murky around holidays/weekends, as people take time off or checkout on Friday earlier. But this looks fine.
You also need a Review from one area expert (for JFR, Markus definitely qualifies), and another Review from any other reviewer. I'll do it shortly.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/26800#issuecomment-3200112542
More information about the hotspot-jfr-dev
mailing list