RFR: 8367949: JFR: MethodTrace double-counts methods that catch their own exceptions

Erik Gahlin egahlin at openjdk.org
Sun Dec 21 17:15:10 UTC 2025


Could I have a review of a PR that changes how the instrumentation of the MethodTrace and MethodTiming events is implemented, so they handle exceptions in a better way? 

For constructors, the current implementation is still used in certain corner cases. A proper implementation would require data-flow analysis, but for all practical purposes this code should work fine.

Testing: jdk/jdk/jfr

Thanks
Erik

-------------

Commit messages:
 - Trailing whitespace
 - Fix trailing whitespaec
 - Fix whitespaces
 - Initial

Changes: https://git.openjdk.org/jdk/pull/28947/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28947&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8367949
  Stats: 361 lines in 5 files changed: 331 ins; 1 del; 29 mod
  Patch: https://git.openjdk.org/jdk/pull/28947.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28947/head:pull/28947

PR: https://git.openjdk.org/jdk/pull/28947


More information about the hotspot-jfr-dev mailing list