RFR: 8367949: JFR: MethodTrace double-counts methods that catch their own exceptions
khanbilal732
duke at openjdk.org
Sun Dec 21 19:56:53 UTC 2025
On Sun, 21 Dec 2025 16:22:25 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of a PR that changes how the instrumentation of the MethodTrace and MethodTiming events is implemented, so they handle exceptions in a better way?
>
> For constructors, the current implementation is still used in certain corner cases. A proper implementation would require data-flow analysis, but for all practical purposes this code should work fine.
>
> Testing: jdk/jdk/jfr
>
> Thanks
> Erik
Marked as reviewed by khanbilal732 at github.com (no known OpenJDK username).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28947#pullrequestreview-3601947729
More information about the hotspot-jfr-dev
mailing list