From egahlin at openjdk.org Tue Feb 4 22:42:12 2025 From: egahlin at openjdk.org (Erik Gahlin) Date: Tue, 4 Feb 2025 22:42:12 GMT Subject: RFR: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC In-Reply-To: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> References: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> Message-ID: On Tue, 4 Feb 2025 18:19:18 GMT, Robert Toyonaga wrote: > Just a tiny test case fix. The test was previously checking the wrong events. Marked as reviewed by egahlin (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/23445#pullrequestreview-2594224962 From dholmes at openjdk.org Wed Feb 5 01:33:27 2025 From: dholmes at openjdk.org (David Holmes) Date: Wed, 5 Feb 2025 01:33:27 GMT Subject: RFR: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC In-Reply-To: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> References: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> Message-ID: On Tue, 4 Feb 2025 18:19:18 GMT, Robert Toyonaga wrote: > Just a tiny test case fix. The test was previously checking the wrong events. Seems good and trivial. Thanks ------------- Marked as reviewed by dholmes (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23445#pullrequestreview-2594430295 From duke at openjdk.org Wed Feb 5 13:17:17 2025 From: duke at openjdk.org (Robert Toyonaga) Date: Wed, 5 Feb 2025 13:17:17 GMT Subject: RFR: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC In-Reply-To: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> References: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> Message-ID: On Tue, 4 Feb 2025 18:19:18 GMT, Robert Toyonaga wrote: > Just a tiny test case fix. The test was previously checking the wrong events. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23445#issuecomment-2636823449 From duke at openjdk.org Wed Feb 5 13:17:17 2025 From: duke at openjdk.org (duke) Date: Wed, 5 Feb 2025 13:17:17 GMT Subject: RFR: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC In-Reply-To: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> References: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> Message-ID: On Tue, 4 Feb 2025 18:19:18 GMT, Robert Toyonaga wrote: > Just a tiny test case fix. The test was previously checking the wrong events. @roberttoyonaga Your change (at version 8fa82737424315596ae8ff1e5cdaae8933a8e623) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23445#issuecomment-2636825797 From duke at openjdk.org Wed Feb 5 13:33:59 2025 From: duke at openjdk.org (Robert Toyonaga) Date: Wed, 5 Feb 2025 13:33:59 GMT Subject: RFR: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC [v2] In-Reply-To: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> References: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> Message-ID: > Just a tiny test case fix. The test was previously checking the wrong events. Robert Toyonaga has updated the pull request incrementally with two additional commits since the last revision: - Revert "wip" This reverts commit 20647cd78e904b53536c87c19b4b85e2ed053b9b. - wip ------------- Changes: - all: https://git.openjdk.org/jdk/pull/23445/files - new: https://git.openjdk.org/jdk/pull/23445/files/8fa82737..2a7ebdc6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=23445&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=23445&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/23445.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23445/head:pull/23445 PR: https://git.openjdk.org/jdk/pull/23445 From duke at openjdk.org Wed Feb 5 15:55:12 2025 From: duke at openjdk.org (duke) Date: Wed, 5 Feb 2025 15:55:12 GMT Subject: RFR: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC [v2] In-Reply-To: References: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> Message-ID: On Wed, 5 Feb 2025 13:33:59 GMT, Robert Toyonaga wrote: >> Just a tiny test case fix. The test was previously checking the wrong events. > > Robert Toyonaga has updated the pull request incrementally with two additional commits since the last revision: > > - Revert "wip" > > This reverts commit 20647cd78e904b53536c87c19b4b85e2ed053b9b. > - wip @roberttoyonaga Your change (at version 2a7ebdc6251bb83b705c742e2113b3b197fab38f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk/pull/23445#issuecomment-2637314355 From dholmes at openjdk.org Thu Feb 6 01:52:57 2025 From: dholmes at openjdk.org (David Holmes) Date: Thu, 6 Feb 2025 01:52:57 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing Message-ID: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. JDK-8348190: Framework for tracing makefile inclusion and parsing The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. Thanks. ------------- Commit messages: - Revert "8348190: Framework for tracing makefile inclusion and parsing" Changes: https://git.openjdk.org/jdk/pull/23481/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23481&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349511 Stats: 2717 lines in 273 files changed: 501 ins; 1663 del; 553 mod Patch: https://git.openjdk.org/jdk/pull/23481.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23481/head:pull/23481 PR: https://git.openjdk.org/jdk/pull/23481 From darcy at openjdk.org Thu Feb 6 02:04:15 2025 From: darcy at openjdk.org (Joe Darcy) Date: Thu, 6 Feb 2025 02:04:15 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote: > This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. > > JDK-8348190: Framework for tracing makefile inclusion and parsing > > The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. > > Thanks. Approving clean backout. ------------- Marked as reviewed by darcy (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23481#pullrequestreview-2597463613 From dholmes at openjdk.org Thu Feb 6 02:44:08 2025 From: dholmes at openjdk.org (David Holmes) Date: Thu, 6 Feb 2025 02:44:08 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 02:01:47 GMT, Joe Darcy wrote: >> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. >> >> JDK-8348190: Framework for tracing makefile inclusion and parsing >> >> The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. >> >> Thanks. > > Approving clean backout. Thanks @jddarcy ! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23481#issuecomment-2638687813 From mikael at openjdk.org Thu Feb 6 02:54:17 2025 From: mikael at openjdk.org (Mikael Vidstedt) Date: Thu, 6 Feb 2025 02:54:17 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote: > This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. > > JDK-8348190: Framework for tracing makefile inclusion and parsing > > The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. > > Thanks. Marked as reviewed by mikael (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/23481#pullrequestreview-2597531112 From dholmes at openjdk.org Thu Feb 6 02:54:18 2025 From: dholmes at openjdk.org (David Holmes) Date: Thu, 6 Feb 2025 02:54:18 GMT Subject: RFR: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 02:48:21 GMT, Mikael Vidstedt wrote: >> This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. >> >> JDK-8348190: Framework for tracing makefile inclusion and parsing >> >> The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. >> >> Thanks. > > Marked as reviewed by mikael (Reviewer). Thanks @vidmik ! ------------- PR Comment: https://git.openjdk.org/jdk/pull/23481#issuecomment-2638701374 From dholmes at openjdk.org Thu Feb 6 02:54:18 2025 From: dholmes at openjdk.org (David Holmes) Date: Thu, 6 Feb 2025 02:54:18 GMT Subject: Integrated: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing In-Reply-To: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> References: <2bf6g3iLVTSpqlp0ka4LeAovJRyPvdibwFZsONUGPI4=.3d01a784-5e93-4c78-87c6-a31c948a81c0@github.com> Message-ID: On Thu, 6 Feb 2025 01:32:51 GMT, David Holmes wrote: > This reverts commit 61465883b465a184e31e7a03e2603d29ab4815a4. > > JDK-8348190: Framework for tracing makefile inclusion and parsing > > The above issue caused problems in the Oracle closed builds and so needs to be backed out until that is addressed. > > Thanks. This pull request has now been integrated. Changeset: 64bd8d25 Author: David Holmes URL: https://git.openjdk.org/jdk/commit/64bd8d2592d26e02a7f2f96caa47cba5e158aaa2 Stats: 2717 lines in 273 files changed: 501 ins; 1663 del; 553 mod 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing Reviewed-by: darcy, mikael ------------- PR: https://git.openjdk.org/jdk/pull/23481 From duke at openjdk.org Mon Feb 17 19:57:20 2025 From: duke at openjdk.org (duke) Date: Mon, 17 Feb 2025 19:57:20 GMT Subject: Withdrawn: 8310996: Add JFR event for connect operations In-Reply-To: <9WgigdK6VDa5UjTuNSUw1A_cn0PUzhZxdl3REdSzZz4=.c3307452-0fd0-4392-89d3-6c050c587f3d@github.com> References: <9WgigdK6VDa5UjTuNSUw1A_cn0PUzhZxdl3REdSzZz4=.c3307452-0fd0-4392-89d3-6c050c587f3d@github.com> Message-ID: <6sD5BK942SQuYweZCugrpTIeQYwDu_5TTfqxXn2iyxI=.79bae3dc-9ad0-4a1c-be03-b62d39d41043@github.com> On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote: > Adds a JFR event for socket connect operations. > > Existing tests TestSocketEvents and TestSocketChannelEvents modified to also check for connect events. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk/pull/21528 From acobbs at openjdk.org Thu Feb 20 21:05:22 2025 From: acobbs at openjdk.org (Archie Cobbs) Date: Thu, 20 Feb 2025 21:05:22 GMT Subject: RFR: 8261669: Add lint warning for widening primitive conversions that lose information Message-ID: This PR is a prototype to stimulate discussion of [JDK-8261669](https://bugs.openjdk.org/browse/JDK-8261669), which seeks to add more warnings when an implicit cast of a primitive value might lose information. This can possibly happen when converting an `int` to `float`, or when converting a `long` to `float` or `double`. Java does not require an explicit cast for such assignments, even though they may result in information loss. I'm interested in feedback both on whether this is a good idea and also the approach taken - thanks! Currently, we generate this warning, but only for assignment operators, e.g.: int x = 0; x += 1.0f; // warning here This PR would add warnings for two additional cases, (a) regular assignments and (b) method parameters, e.g.: void method(float f) { } ... float a = 0x10000001; // warning here method(0x10000001); // warning here It would _not_ generate a warning in cases (a) and (b) when the value is a constant value and we can determine that no information would be lost, e.g.: float f1 = 0x10000000; // no warning here The definition of "no information would be lost" is that a round trip results in the same value, e.g., `(int)(float)x == x`. In the examples above, `0x10000000` survives the round trip but `0x10000001` does not. As usual, warnings can be suppressed via `@SuppressWarnings` or by adding an explicit cast: float a = (float)0x10000001; // no warning here ------------- Commit messages: - Warn for more widening primitive conversions that lose information. Changes: https://git.openjdk.org/jdk/pull/23718/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23718&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8261669 Stats: 187 lines in 15 files changed: 149 ins; 0 del; 38 mod Patch: https://git.openjdk.org/jdk/pull/23718.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23718/head:pull/23718 PR: https://git.openjdk.org/jdk/pull/23718 From syan at openjdk.org Fri Feb 21 03:35:24 2025 From: syan at openjdk.org (SendaoYan) Date: Fri, 21 Feb 2025 03:35:24 GMT Subject: RFR: 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing Message-ID: Hi all, Test jdk/jfr/event/compiler/TestCodeCacheFull.java fails with option `-XX:-UseCodeCacheFlushing`, because this test is incompatible with `-XX:-UseCodeCacheFlushing` when `-XX:+SegmentedCodeCache` is enable, the detail analyze has been recorded by [JDK-8350386](https://bugs.openjdk.org/browse/JDK-8350386). This PR add `-XX:+UseCodeCacheFlushing` JVM option to test header make this test run passes whenever test receive `-XX:-UseCodeCacheFlushing` from outside or not. Change has been verified locally, test-fix only, no risk. ------------- Commit messages: - 8350386: Test TestCodeCacheFull.java fails with option -XX:-UseCodeCacheFlushing Changes: https://git.openjdk.org/jdk/pull/23721/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23721&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8350386 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/23721.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/23721/head:pull/23721 PR: https://git.openjdk.org/jdk/pull/23721 From duke at openjdk.org Thu Feb 27 13:03:03 2025 From: duke at openjdk.org (Robert Toyonaga) Date: Thu, 27 Feb 2025 13:03:03 GMT Subject: Integrated: 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC In-Reply-To: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> References: <-29UVi0_-B2NGs3H9qXBFJg80IbwC2saJB9jU-cSRQc=.27eb2890-6938-41d5-9511-bb995739ee2a@github.com> Message-ID: On Tue, 4 Feb 2025 18:19:18 GMT, Robert Toyonaga wrote: > Just a tiny test case fix. The test was previously checking the wrong events. This pull request has now been integrated. Changeset: e80b76b6 Author: Robert Toyonaga Committer: SendaoYan URL: https://git.openjdk.org/jdk/commit/e80b76b663c6b82a353665fd68819cc9295ec429 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC Reviewed-by: egahlin, dholmes ------------- PR: https://git.openjdk.org/jdk/pull/23445