RFR: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types

Markus Grönlund mgronlun at openjdk.org
Tue Jan 7 16:23:35 UTC 2025


On Thu, 12 Dec 2024 13:24:51 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of PR that improves the query language for 'jfr view' so it can handle a wildcard with multiple event types, e.g. "SELECT * FROM E1, E2".
> 
> Every field has an index which corresponds to where it is located in resultFields array. Today, the same index can appear multiple times. See FieldBuilder::createWildcardField how this can happen when there are multiple event/filter types. The fix is to set the index after all fields have been added. 
> 
> Testing: jdk/jdk/jfr + manual check
> 
> Thanks
> Erik

Marked as reviewed by mgronlun (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22711#pullrequestreview-2534838623


More information about the hotspot-jfr-dev mailing list