Integrated: 8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
Erik Gahlin
egahlin at openjdk.org
Wed Jan 8 16:07:32 UTC 2025
On Thu, 12 Dec 2024 13:24:51 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of PR that improves the query language for 'jfr view' so it can handle a wildcard with multiple event types, e.g. "SELECT * FROM E1, E2".
>
> Every field has an index which corresponds to where it is located in resultFields array. Today, the same index can appear multiple times. See FieldBuilder::createWildcardField how this can happen when there are multiple event/filter types. The fix is to set the index after all fields have been added.
>
> Testing: jdk/jdk/jfr + manual check
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: 3fe08186
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/3fe08186b1d6dbc17d4f14d8288ce3c7c6651004
Stats: 10 lines in 2 files changed: 8 ins; 2 del; 0 mod
8346099: JFR: Query for 'jfr view' can't handle wildcard with multiple event types
Reviewed-by: mgronlun
-------------
PR: https://git.openjdk.org/jdk/pull/22711
More information about the hotspot-jfr-dev
mailing list