RFR: 8347287: JFR: Remove use of Security Manager
Andrey Turbanov
aturbanov at openjdk.org
Fri Jan 10 10:44:39 UTC 2025
On Tue, 17 Dec 2024 09:25:17 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of PR that removes Java related code not needed when the Security Manager is disabled.
>
> Testing: tier1 + test/jdk/jdk/jfr
>
> Thanks
> Erik
src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/JFC.java line 114:
> 112: + MAXIMUM_FILE_SIZE + " characters can't be read.");
> 113: }
> 114: try (InputStream r = Files.newInputStream(knownPath);) {
Suggestion:
try (InputStream r = Files.newInputStream(knownPath)) {
src/jdk.jfr/share/classes/jdk/jfr/internal/jfc/JFC.java line 198:
> 196: Path file = path.resolveSibling(name + extension);
> 197: if (Files.exists(file) && !Files.isDirectory(file)) {
> 198: try (Reader r = Files.newBufferedReader(file);) {
Suggestion:
try (Reader r = Files.newBufferedReader(file)) {
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22787#discussion_r1910190020
PR Review Comment: https://git.openjdk.org/jdk/pull/22787#discussion_r1910190392
More information about the hotspot-jfr-dev
mailing list