Integrated: 8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac

Severin Gehwolf sgehwolf at openjdk.org
Tue Jan 14 09:20:46 UTC 2025


On Mon, 13 Jan 2025 15:39:19 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please review this test-only fix. Apparently there are some test configurations out there that run `jdk/jfr/jvm/TestModularImage.java` with limited modules. Specifically `--limit-modules java.base,jdk.jfr`. For this particular test that is not sufficient to be able to run the test. `TestModularImage.java` uses the `ToolProvider` API to get a hold of `javac` as well as for `jlink` without them being present the test should be skipped.
> 
> I've done that by adding those two required modules in the `@modules` tag.
> 
> Testing:
> - [x] GHA
> - [x] `jdk/jfr/jvm/TestModularImage.java` with test option `--limit-modules jdk.jfr,java.base` which now skips the test (instead of failing the test). Running `TestModularImage.java` without the `--limit-modules` option and it passes.
> 
> Thoughts?

This pull request has now been integrated.

Changeset: 39676963
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/3967696386ecc706927f05dfae0841b3f23e319d
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8347496: Test jdk/jfr/jvm/TestModularImage.java fails after JDK-8347124: No javac

Reviewed-by: egahlin, dholmes

-------------

PR: https://git.openjdk.org/jdk/pull/23079


More information about the hotspot-jfr-dev mailing list