[jdk25] RFR: 8360287: JFR: PlatformTracer class should be loaded lazily
Erik Gahlin
egahlin at openjdk.org
Tue Jul 1 08:00:40 UTC 2025
On Mon, 30 Jun 2025 19:45:32 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
>> 8360287: JFR: PlatformTracer class should be loaded lazily
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/settings/MethodSetting.java line 45:
>
>> 43: public final class MethodSetting extends FilterSetting {
>> 44: private final Modification modification;
>> 45: private volatile static boolean initialized;
>
> Let's use blessed modifiers order
> Suggestion:
>
> private static volatile boolean initialized;
I'd prefer to keep this backport as is. If you believe the change is necessary, please file a separate bug and backport it. In general, it's helpful to suggest small changes early on to avoid re-reviews and unclean backports.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26040#discussion_r2176730411
More information about the hotspot-jfr-dev
mailing list