[jdk25] RFR: 8361338: JFR: Min and max time in MethodTime event is confusing

Aleksey Shipilev shade at openjdk.org
Mon Jul 7 08:14:38 UTC 2025


On Sun, 6 Jul 2025 19:17:42 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> 8361338: JFR: Min and max time in MethodTime event is confusing

Marked as reviewed by shade (Reviewer).

src/jdk.jfr/share/classes/jdk/jfr/internal/tracing/TimedClass.java line 76:

> 74:                     if (max == Long.MIN_VALUE) {
> 75:                         max = average;
> 76:                     }

For the future: I think `Math.min/max` below subsume these checks for `Long.MAX/MIN_VALUE`.

-------------

PR Review: https://git.openjdk.org/jdk/pull/26145#pullrequestreview-2992688756
PR Review Comment: https://git.openjdk.org/jdk/pull/26145#discussion_r2189318564


More information about the hotspot-jfr-dev mailing list