RFR: 8364090: Dump JFR recording on CrashOnOutOfMemoryError [v4]

[Erik Gahlin]

On Tue, 29 Jul 2025 06:20:15 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Yasumasa Suenaga has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add testcase
>
> test/jdk/jdk/jfr/event/oldobject/TestEmergencyDumpAtOOM.java line 70:
> 
>> 68:         var p = ProcessTools.createTestJavaProcessBuilder(args).start();
>> 69:         p.waitFor();
>> 70:         var output = new OutputAnalyzer(p);
> 
> I'm not a big fan of var, since it degrades the readability. I like to know which types I deal with when reading code.
> 
> Not sure what others think, though, or if there is a Java style guideline similar to our hotspot style guide.

I'm going to run some testing before approving. 

I don't have a strong opinion on var, but Stuart Marks wrote about when to use it a few years ago:
https://openjdk.org/projects/amber/guides/lvti-style-guide

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26468#discussion_r2239410134