RFR: 8358448: JFR: Incorrect time unit for MethodTiming event

Markus Grönlund mgronlun at openjdk.org
Tue Jun 3 14:49:51 UTC 2025


On Tue, 3 Jun 2025 14:26:22 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of a PR that fixes a regression introduced with [JDK-8047756](https://bugs.openjdk.org/projects/JDK/issues/JDK-8047756)?
> 
> The default unit for `@Timespan` in Java is nanos, but it should be set to ticks. Prior to JDK-8047756, annotations were taken from native code, so ticks were used.
> 
> Testing: 
> 100 * test/jdk//jdk/jfr/event/tracing/TestMethodTimingEvent.java on Windows, Linux and MacOS 
> test/jdk//jdk/jfr/*
> 
> Thanks
> Erik

Looks good.

-------------

Marked as reviewed by mgronlun (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25615#pullrequestreview-2892825125


More information about the hotspot-jfr-dev mailing list