Integrated: 8358448: JFR: Incorrect time unit for MethodTiming event
Erik Gahlin
egahlin at openjdk.org
Tue Jun 3 16:05:43 UTC 2025
On Tue, 3 Jun 2025 14:26:22 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:
> Could I have a review of a PR that fixes a regression introduced with [JDK-8047756](https://bugs.openjdk.org/projects/JDK/issues/JDK-8047756)?
>
> The default unit for `@Timespan` in Java is nanos, but it should be set to ticks. Prior to JDK-8047756, annotations were taken from native code, so ticks were used.
>
> Testing:
> 100 * test/jdk//jdk/jfr/event/tracing/TestMethodTimingEvent.java on Windows, Linux and MacOS
> test/jdk//jdk/jfr/*
>
> Thanks
> Erik
This pull request has now been integrated.
Changeset: d7def20a
Author: Erik Gahlin <egahlin at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/d7def20afa045a0bb154655b02e56346f7f51347
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
8358448: JFR: Incorrect time unit for MethodTiming event
Reviewed-by: mgronlun, ayang
-------------
PR: https://git.openjdk.org/jdk/pull/25615
More information about the hotspot-jfr-dev
mailing list