RFR: 8358536: jdk/jfr/api/consumer/TestRecordingFileWrite.java times out

Markus Grönlund mgronlun at openjdk.org
Wed Jun 4 13:19:50 UTC 2025


On Wed, 4 Jun 2025 04:15:12 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

> Could I have a review of the PR that fixes a regression caused by [JDK-8356698](https://bugs.openjdk.org/browse/JDK-8356698)?
> 
> The problem is that PrettyWriter is also used by RecordedObject::toString, and by allocating the priority queue when PrettyWriter is instantiated, the memory pressure increases enormously. The fix is to allocate them lazily. 
> 
> Testing: 10 * jdk/jdk/jfr/ on Linux, MacOS and Windows.
> 
> Thanks
> Erik

Looks good.

-------------

Marked as reviewed by mgronlun (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25633#pullrequestreview-2896381131


More information about the hotspot-jfr-dev mailing list