RFR: 8353235: Test jdk/jfr/api/metadata/annotations/TestPeriod.java fails with IllegalArgumentException

SendaoYan syan at openjdk.org
Mon Mar 31 15:50:15 UTC 2025


On Mon, 31 Mar 2025 14:52:36 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Hi all,
>> 
>> In test jdk/jfr/api/metadata/annotations/TestPeriod.java, the tested class `PeriodicEvent` extends `Event`, bug `Event` has three event types `enabled/stackTrace/threshold` by default. So we need to add `period` event type before test manually.
>> 
>> Change has been verified locally, test-fix only, no risk.
>
> Marked as reviewed by egahlin (Reviewer).

Thanks for the review @egahlin.

I think I should integrate this PR now, to avoid test noisy of CI/CD. Do not wait 24 hours.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24320#issuecomment-2766641795


More information about the hotspot-jfr-dev mailing list