RFR: 8352251: Implement JEP 518: JFR Cooperative Sampling [v20]

Tue May 13 20:22:57 UTC 2025

On Tue, 13 May 2025 07:05:58 GMT, Erik Österlund <eosterlund at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   tiny adjustments
>
> src/hotspot/share/runtime/safepointMechanism.cpp line 135:
> 
>> 133: }
>> 134: 
>> 135: static inline bool has_handshake_operation(JavaThread* jt, bool allow_suspend, bool check_async) {
> 
> This function sounds like it checks if there is a pending handshake operation, but it also does the actual processing of discovered handshake operations, which is a bit misleading. This refactoring looks a bit orthogonal to what you are doing. Could we revert this refactoring and revisit after the integration?

Absolutely, reverting now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24296#discussion_r2087568350