RFR: 8352251: Implement JEP 518: JFR Cooperative Sampling [v23]

Markus Grönlund mgronlun at openjdk.org
Thu May 15 20:40:57 UTC 2025


On Thu, 15 May 2025 16:52:44 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   growable array constructur without default initialization
>
> src/hotspot/cpu/x86/interp_masm_x86.cpp line 1059:
> 
>> 1057:   bind(L_continuation);
>> 1058:   lea(sender_sp, Address(rbp, frame::sender_sp_offset * wordSize));
>> 1059:   movptr(rbp, Address(sender_sp, (int)(ContinuationEntry::size()))); // Update the frame link.
> 
> Method enterSpecial already sets rbp so we can read from current rbp as with the normal case.

I don't think so. That was why I had to do all this special handling for the Continuations.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24296#discussion_r2091924241


More information about the hotspot-jfr-dev mailing list