RFR: 8352251: Implement JEP 518: JFR Cooperative Sampling [v23]

[Patricio Chilano Mateo]

On Thu, 15 May 2025 20:49:22 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> I don't think so. That was why I had to do all this special handling for the Continuations.
>
> If I recall, which I don't, as it has been too long, the issue here is that since the IP is still in the interpreter, the rbp referenced in the enterSpecial frame links to an EntryFrame, which is not interpreter code. At least, what is linked in the Continuation is Java code, which can also be compiled; in this case, we can handle it. However, the challenge is to move the rbp, knowing that your IP is still in interpreter code. Can I handle that situation? That becomes the question.

So we would just need to check when creating the request if the fp points to the ContinuationEntry, which is easy to do, and if so create the request with the sender (as I see you already do in one of the cases). This will also cover the case where the return pc is the return_barrier, which should in fact be more common than this case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24296#discussion_r2092007195