RFR: 8352251: Implement JEP 518: JFR Cooperative Sampling [v23]

Patricio Chilano Mateo pchilanomate at openjdk.org
Thu May 15 22:55:53 UTC 2025


On Thu, 15 May 2025 22:35:05 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> So we would just need to check when creating the request if the fp points to the ContinuationEntry, which is easy to do, and if so create the request with the sender (as I see you already do in one of the cases). This will also cover the case where the return pc is the return_barrier, which should in fact be more common than this case.
>
> Also, thinking more about it if we are in the return_barrier case it’s the vthread that will continue executing. So one option could be to still create the request with the sender of the ContinuationEntry and just add a condition when processing it to check if the frame in the request is within the continuation.

Another case we are missing is when we freeze. We should call `Jfr::check_and_process_sample_request` before copying the frames to the heap.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24296#discussion_r2092069972


More information about the hotspot-jfr-dev mailing list