RFR: 8352251: Implement JEP 518: JFR Cooperative Sampling [v23]

Markus Grönlund mgronlun at openjdk.org
Tue May 20 21:24:17 UTC 2025


On Thu, 15 May 2025 16:49:42 GMT, Patricio Chilano Mateo <pchilanomate at openjdk.org> wrote:

>> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   growable array constructur without default initialization
>
> src/hotspot/share/jfr/periodic/sampling/jfrSampleRequest.cpp line 91:
> 
>> 89: static inline address continuation_frame_sender_pc(void* sp) {
>> 90:   assert(sp != nullptr, "invariant");
>> 91:   return static_cast<address>(sp) + (ContinuationEntry::size() + wordSize);
> 
> Seems we are missing a dereference.

Thanks for noting this. It has been removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24296#discussion_r2098893937


More information about the hotspot-jfr-dev mailing list