RFR: 8352251: Implement JEP 518: JFR Cooperative Sampling [v32]

Markus Grönlund mgronlun at openjdk.org
Wed May 21 10:44:01 UTC 2025


On Tue, 20 May 2025 22:32:47 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> This is the implementation of JEP [JDK-8350338 Cooperative JFR Sampling](https://bugs.openjdk.org/browse/JDK-8350338).
>> 
>> Implementations in this change set are provided and have been tested on the following platforms:
>> 
>> - windows-x64
>> - windows-x64-debug
>> - linux-x64
>> - linux-x64-debug
>> - macosx-x64
>> - macosx-x64-debug
>> - linux-aarch64
>> - linux-aarch64-debug
>> - macosx-aarch64
>> - macosx-aarch64-debug
>> 
>> Testing: tier1-6, jdk_jfr, stress testing.
>> 
>> Platform porters note:
>> Some platform-specific code needs to be provided, mainly in the interpreter. Take a look at the following files for changes:
>> 
>> - src/hotspot/cpu/x86/frame_x86.cpp
>> - src/hotspot/cpu/x86/interp_masm_x86.cpp
>> - src/hotspot/cpu/x86/interp_masm_x86.hpp
>> - src/hotspot/cpu/x86/javaFrameAnchor_x86.hpp
>> - src/hotspot/cpu/x86/macroAssembler_x86.cpp
>> - src/hotspot/cpu/x86/macroAssembler_x86.hpp
>> - src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp
>> - src/hotspot/cpu/x86/templateTable_x86.cpp
>> - src/hotspot/os_cpu/linux_x86/javaThread_linux_x86.hpp
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   skip level mismatch

> Hi, Could you please incorporate this change for riscv? Thanks. [RealFYang at be8eac4](https://github.com/RealFYang/jdk/commit/be8eac493bef865d7825848f0b31a06d95b08efc) This passed `hotspot_serviceability` and `jdk_svc` tests on linux-riscv64 platform with both release and fastdebug builds.

Thanks a lot for the patch.

Unfortunately we changed direction a bit after you submitted it, because of implementation difficulties on other platforms.

Can you please take a look at the new and simpler version?

Thanks
Markus

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24296#issuecomment-2897474597


More information about the hotspot-jfr-dev mailing list