RFR: 8352738: Implement JEP 520: JFR Method Timing and Tracing

Erik Gahlin egahlin at openjdk.org
Thu May 22 19:59:56 UTC 2025


On Thu, 22 May 2025 12:22:23 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Could I have a review of this enhancement that will add tracing capabilities to JFR? There are opportunities for performance improvements in the implementation, but I would rather add them later and separately.
>> 
>> Testing: tier 1-3, test/jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> src/jdk.jfr/share/classes/jdk/jfr/internal/tracing/PlatformTracer.java line 249:
> 
>> 247:     }
>> 248: 
>> 249:     private synchronized static void reset() {
> 
> Any sense to do  `synchronized` here, given that `timed{Methods,Classes}` are `ConcurrentHashMap`-s?

It's only used by PlatformTracer::initialize(), so it can removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25306#discussion_r2103305030


More information about the hotspot-jfr-dev mailing list