RFR: 8352738: Implement JEP 520: JFR Method Timing and Tracing

[Erik Gahlin]

On Thu, 22 May 2025 10:57:15 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Could I have a review of this enhancement that will add tracing capabilities to JFR? There are opportunities for performance improvements in the implementation, but I would rather add them later and separately.
>> 
>> Testing: tier 1-3, test/jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp line 81:
> 
>> 79:                                                     jint* new_class_data_len,
>> 80:                                                     unsigned char** new_class_data) {
>> 81:   if (class_being_redefined == nullptr) {
> 
> OK, so this method is now completely empty. Do you even need it then? Or is it a part of some external API? If so, put a comment here, so no one removes it accidentally.

It's been dead code for a long time, but it makes sense to remove the method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25306#discussion_r2104614207