RFR: 8352738: Implement JEP 520: JFR Method Timing and Tracing
Markus Grönlund
mgronlun at openjdk.org
Fri May 23 17:28:58 UTC 2025
On Fri, 23 May 2025 15:24:48 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Why release_store_fence() over release_store() in this context?
>
> `release_store_fence` would get stronger seqcst mode, instead of more relaxed acquire/release with just `release_store`. My rule of thumb is to default to a strongest mode, unless we can prove weaker mode is sufficient. Acquire/release is okay for simple uni-directional pub/sub transfer, which this one _looks_ to be, but I am not 100% sure.
A good rule of thumb.
In this case, it is an unidirectional pub/sub transfer, so release_store() will be good enough.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25306#discussion_r2105095604
More information about the hotspot-jfr-dev
mailing list