RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v5]
Johannes Bechberger
jbechberger at openjdk.org
Sun May 25 08:37:50 UTC 2025
On Sun, 25 May 2025 08:13:24 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> The ThreadCrashProtection deeply worries me; I have argued against this technique several times in the past, so I will save us the time here. But I don't see it used anywhere in this PR, so is this a remnant from older versions?
You're right, I don't know how this ended up in this PR. I'll remove it.
> To make the NoResourceMark safe, you need to guard every single arena allocation path. But I would guess that is way too expensive even for debug builds.
Good to know, then I'll remove the NoResourceMark for now too.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25302#issuecomment-2907692503
More information about the hotspot-jfr-dev
mailing list