RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v5]

Markus Grönlund mgronlun at openjdk.org
Sun May 25 21:11:52 UTC 2025


On Sun, 25 May 2025 20:49:37 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> src/hotspot/share/jfr/support/jfrThreadLocal.hpp line 378:
>> 
>>> 376: 
>>> 377:   void unset_cpu_timer() {
>>> 378:     _has_cpu_timer = false;
>> 
>> Do we really need a separate bool to understand whether the thread has a timer? Can't that information be deduced from the timer_t?
>
> Do we want to make hard assumptions on timer_t?

You can have a field as a pointer: timer_t* timer and test it, timer != nullptr.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2106307666


More information about the hotspot-jfr-dev mailing list