RFR: 8352738: Implement JEP 520: JFR Method Timing and Tracing [v5]

Markus Grönlund mgronlun at openjdk.org
Tue May 27 15:27:55 UTC 2025


On Tue, 27 May 2025 12:36:43 GMT, Erik Gahlin <egahlin at openjdk.org> wrote:

>> Could I have a review of this enhancement that will add tracing capabilities to JFR? There are opportunities for performance improvements in the implementation, but I would rather add them later and separately.
>> 
>> Testing: tier 1-3, test/jdk/jdk/jfr
>> 
>> Thanks
>> Erik
>
> Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove METHOD_FLAG_USED_PREVIOUS_EPOCH_BIT(method)

src/hotspot/share/jfr/support/methodtracer/jfrMethodTracer.cpp line 218:

> 216: // jvmtiRedefineClassses::redefine_single_class() has finished so we are still at a safepoint.
> 217: // If the original klass is not already in the list, add it and also dynamically tag all
> 218: // artifacts that have the sticky bit set. If the klass represents has an associated TimedClass,

"If the klass represents" -> "if the klass has an associated..."

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25306#discussion_r2109505915


More information about the hotspot-jfr-dev mailing list