RFR: 8342818: Implement JEP 509: JFR CPU-Time Profiling [v24]
Johannes Bechberger
jbechberger at openjdk.org
Fri May 30 09:23:05 UTC 2025
On Fri, 30 May 2025 09:04:44 GMT, Daishi Tabata <dtabata at openjdk.org> wrote:
>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix tiny issue
>
> src/hotspot/share/jfr/metadata/metadata.xml line 975:
>
>> 973: </Event>
>> 974:
>> 975: <Event name="CPUTimeSampleLoss" category="Java Virtual Machine, Profiling" label="CPU Time Method Profiling Lost Samples" description="Records that the CPU time sampler lost samples"
>
> I'm not a reviewer, but I just wanted to comment something I noticed.
> The JEP document says CPUTimeSampleLos'**t**', but the implementation says CPUTimeSampleLos'**s**'. Which one is correct?
> A sentence from the JEP document:
>
> Another new event, `jdk.CPUTimeSampleLost`, is emitted when samples are lost ...
Thanks for catching this mistake. I'll fix it this afternoon.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25302#discussion_r2115488808
More information about the hotspot-jfr-dev
mailing list